-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Closed
Labels
Area-CompilersFeature - TuplesTuplesTuplesResolution-FixedThe bug has been fixed and/or the requested behavior has been implementedThe bug has been fixed and/or the requested behavior has been implemented
Milestone
Description
See comment
I missed this during the previous review. It might be inappropriate to use HasAnyErrors here. There are at least two reasons for that:
It resolves lazy diagnostics, which could create circularity problems in certain contexts.
Lazy errors shouldn't really fail the binding. An example would be an obsolete Deconstruct method. Yes, it is an error to use it, but that shouldn't prevent us from recording the actual binding information and continuing to the next level. I.e. we shouldn't complain that we couldn't find a suitable method.
Consider using HasAnyResolvedErrors instead and adding a test with an obsolete Deconstruct method.
Split this issue from the umbrella for deconstruction work items #11299
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-CompilersFeature - TuplesTuplesTuplesResolution-FixedThe bug has been fixed and/or the requested behavior has been implementedThe bug has been fixed and/or the requested behavior has been implemented