Skip to content

Block EnC on and around tuple equality#25402

Closed
jcouv wants to merge 2 commits intodotnet:features/tuple-equalityfrom
jcouv:tuple-enc
Closed

Block EnC on and around tuple equality#25402
jcouv wants to merge 2 commits intodotnet:features/tuple-equalityfrom
jcouv:tuple-enc

Conversation

@jcouv
Copy link
Member

@jcouv jcouv commented Mar 11, 2018

No description provided.

@jcouv jcouv added this to the 15.7 milestone Mar 11, 2018
@jcouv jcouv self-assigned this Mar 11, 2018
@jcouv jcouv requested a review from a team as a code owner March 11, 2018 05:53
@jcouv jcouv added the Feature - Tuples Tuples label Mar 11, 2018
@jcouv jcouv requested review from ivanbasov and tmat March 11, 2018 18:44
@tmat
Copy link
Member

tmat commented Mar 12, 2018

I would think tuple equality should just work. Is there anything in the generated code that would break EnC if it was not blocked?

@jcouv
Copy link
Member Author

jcouv commented Mar 12, 2018

I couldn't remember what are the criteria requiring that a feature needs to be blocked, so I was taking precautions.
The lowered code is a number of temps and a logical expression temp1.Item1 == temp2.Item1 && temp1.Item2 == temp2.Item2 (with some variants for nullable, dynamic and custom operators).

@jcouv
Copy link
Member Author

jcouv commented Mar 12, 2018

From the email thread, I think tuple equality doesn't have EnC concerns (all the temps only live within the containing statement). I'll close. Thanks

@jcouv jcouv closed this Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants