Add suggested tuple equality tests#25486
Merged
jcouv merged 3 commits intodotnet:features/tuple-equalityfrom Mar 16, 2018
Merged
Add suggested tuple equality tests#25486jcouv merged 3 commits intodotnet:features/tuple-equalityfrom
jcouv merged 3 commits intodotnet:features/tuple-equalityfrom
Conversation
jcouv
added
the
PR For Personal Review Only
jcouv
force-pushed
the
merge-fixups
branch
2 times, most recently
from
d749957 to
de6aad8
Compare
jcouv
changed the title
jcouv
removed
the
PR For Personal Review Only
jcouv
commented
Mar 15, 2018
| // | ||
| // Note: all the temps are created in a single bucket (rather than different scopes of applicability) for simplicity | ||
|
|
||
| // PROTOTYPE(tuple-equality) Consider if optimizations from TrivialLiftedComparisonOperatorOptimizations can be applied |
jcouv
commented
Mar 15, 2018
|
|
||
| ERR_TupleSizesMismatchForBinOps = 8373, | ||
| ERR_ExpressionTreeContainsTupleBinOp = 8374, | ||
| WRN_TupleBinopLiteralNameMismatch = 8375, |
Member
Author
There was a problem hiding this comment.
When I merged latest dev15.7.x bits into features/tuple-equality branch yesterday, I had to do a force push because github kept giving me unicorns. This is fixing a merge issue. #Resolved
Member
Author
|
@dotnet/roslyn-compiler This is ready for review (test-only change and fixing a merge issue). Thanks #Resolved |
Contributor
|
@jcouv It looks like tests involving dynamic are failing on CoreClr. Should they be marked as DeskTop only? #Resolved |
AlekseyTs
reviewed
Mar 15, 2018
| } | ||
|
|
||
| [Fact] | ||
| public void AnalysisOfTupleEquality() |
Contributor
There was a problem hiding this comment.
AnalysisOfTupleEquality [](start = 20, length = 23)
It would be good to test the same on an element, including nested tuple literal #Resolved
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From feature review notes and test plan: #22937