Restore feature to tell people when a lambda is unnecessary.#58875
Merged
CyrusNajmabadi merged 38 commits intodotnet:mainfrom Jan 18, 2022
Merged
Restore feature to tell people when a lambda is unnecessary.#58875CyrusNajmabadi merged 38 commits intodotnet:mainfrom
CyrusNajmabadi merged 38 commits intodotnet:mainfrom
Conversation
ghost
added
the
Youssef1313
reviewed
Jan 15, 2022
Youssef1313
reviewed
Jan 15, 2022
.../RemoveUnnecessaryLambdaExpression/CSharpRemoveUnnecessaryLambdaExpressionCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jan 15, 2022
...moveUnnecessaryLambdaExpression/CSharpRemoveUnnecessaryLambdaExpressionDiagnosticAnalyzer.cs
Show resolved
Hide resolved
Youssef1313
reviewed
Jan 15, 2022
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/CodeStyle/CSharpCodeStyleOptions.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jan 15, 2022
...moveUnnecessaryLambdaExpression/CSharpRemoveUnnecessaryLambdaExpressionDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
…/CSharpRemoveUnnecessaryLambdaExpressionDiagnosticAnalyzer.cs Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
…slyn into simplifyLambda
Youssef1313
reviewed
Jan 15, 2022
...moveUnnecessaryLambdaExpression/CSharpRemoveUnnecessaryLambdaExpressionDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jan 15, 2022
...moveUnnecessaryLambdaExpression/CSharpRemoveUnnecessaryLambdaExpressionDiagnosticAnalyzer.cs
Show resolved
Hide resolved
Youssef1313
reviewed
Jan 15, 2022
.../RemoveUnnecessaryLambdaExpression/CSharpRemoveUnnecessaryLambdaExpressionCodeFixProvider.cs
Show resolved
Hide resolved
davidwengier
approved these changes
Jan 18, 2022
...moveUnnecessaryLambdaExpression/CSharpRemoveUnnecessaryLambdaExpressionDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
...moveUnnecessaryLambdaExpression/CSharpRemoveUnnecessaryLambdaExpressionDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
.../RemoveUnnecessaryLambdaExpression/CSharpRemoveUnnecessaryLambdaExpressionCodeFixProvider.cs
Show resolved
Hide resolved
…on/CSharpRemoveUnnecessaryLambdaExpressionDiagnosticAnalyzer.cs Co-authored-by: David Wengier <david.wengier@microsoft.com>
…slyn into simplifyLambda
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40364
Looks like this:
Note the faded sections in the lambda. Invoking the fix gives you:
We used to have this feature, but had to disable it because this 'fix' could make performance worse due to the compiler no longer caching this delegate in the case of some static call. However, now that #58288 has gone in, the compiler will still cache these method group conversions if you are on C#11 or above.
This allows us to reenable the feature.
--
Note: this feature can be entirely disabled by suppressing this diagnostic ID. in that case no messages or fading will occur :)
todo:
Relates to test plan #52192