Fix SyntaxGenerator for checked operators

[Youssef1313]

Fixes #63410

@CyrusNajmabadi What do you think of the fix?

[Youssef1313]

@CyrusNajmabadi This is ready for review.

[CyrusNajmabadi]

what's this guy?

[Youssef1313]

@CyrusNajmabadi A new method that allows me to pass isChecked. I couldn't think of another good way.

[CyrusNajmabadi]

that makes sense. w hy is this virtual though and not abstract?

[Youssef1313]

I incorrectly assumed the type is subclass-able when I saw this:

roslyn/src/Workspaces/Core/Portable/Editing/SyntaxGenerator.cs

Lines 194 to 203 in 8f96b1b

	public virtual SyntaxNode OperatorDeclaration(
	OperatorKind kind,
	IEnumerable<SyntaxNode>? parameters = null,
	SyntaxNode? returnType = null,
	Accessibility accessibility = Accessibility.NotApplicable,
	DeclarationModifiers modifiers = default,
	IEnumerable<SyntaxNode>? statements = null)
	{
	throw new NotImplementedException();
	}

Given there are already non-public abstract methods, it's indeed okay to make the new methods abstract.

This is fixed in the last commit now.

[CyrusNajmabadi]

why virtual and not abstract (applies to all methods like this).

[Youssef1313]

@CyrusNajmabadi SyntaxGenerator is public. Adding new abstract members is breaking.

[CyrusNajmabadi]

SyntaxGenerator has internal-abstracts. It cannot be publicly subclassed :) you're fine adding a new abstract to it.

[Youssef1313]

@CyrusNajmabadi This is ready for another look.

[CyrusNajmabadi]

i think i'd prefer just passing hte operator name along. thsi also includes 'checked' so it can subsume the first two parameters.

[jcouv]

@CyrusNajmabadi Can this be merged?

[Youssef1313]

@CyrusNajmabadi Can you take a look please? Thanks!

[CyrusNajmabadi]

Thanks @Youssef1313 :)