Skip to content

Display standalone parameter names by default#65606

Merged
jjonescz merged 6 commits intodotnet:mainfrom
jjonescz:report-parameter-name-by-default
Dec 5, 2022
Merged

Display standalone parameter names by default#65606
jjonescz merged 6 commits intodotnet:mainfrom
jjonescz:report-parameter-name-by-default

Conversation

@jjonescz
Copy link
Copy Markdown
Member

Fixes #62096 as discussed in #64179 (comment).

@ghost ghost added the Area-Compilers label Nov 25, 2022
@jjonescz jjonescz marked this pull request as ready for review November 25, 2022 14:27
@jjonescz jjonescz requested review from a team as code owners November 25, 2022 14:27
Comment thread src/Compilers/Core/Portable/SymbolDisplay/SymbolDisplayParameterOptions.cs Outdated
Comment thread src/Compilers/CSharp/Portable/Binder/Binder.WithQueryLambdaParametersBinder.cs Outdated
Comment thread src/Compilers/Core/Portable/SymbolDisplay/SymbolDisplayFormat.cs Outdated
@AlekseyTs
Copy link
Copy Markdown
Contributor

Done with review pass (commit 4)

@AlekseyTs
Copy link
Copy Markdown
Contributor

Done with review pass (commit 5)

Copy link
Copy Markdown
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 6)

@jjonescz jjonescz requested a review from cston December 2, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Various diagnostics that reference parameters do not include the parameter name

5 participants