Skip to content

Fix bounds checking for SyntaxTriviaListBuilder indexer#65779

Merged
333fred merged 1 commit intodotnet:mainfrom
Youssef1313:patch-41
Dec 5, 2022
Merged

Fix bounds checking for SyntaxTriviaListBuilder indexer#65779
333fred merged 1 commit intodotnet:mainfrom
Youssef1313:patch-41

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

FAR is only showing two usages of the indexer, both provide a correct index. So as of now, the change can't be noticed. This is to prevent any possible future bugs.

image

@Youssef1313 Youssef1313 requested a review from a team as a code owner December 5, 2022 17:22
@ghost ghost added Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Dec 5, 2022
Comment thread src/Compilers/Core/Portable/Syntax/SyntaxTriviaListBuilder.cs
@333fred 333fred merged commit e3a89ab into dotnet:main Dec 5, 2022
@ghost ghost added this to the Next milestone Dec 5, 2022
@Youssef1313 Youssef1313 deleted the patch-41 branch December 5, 2022 20:18
@Cosifne Cosifne modified the milestones: Next, 17.5 P3 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants