Move BasicBuild to new integration test framework and implement#65889
Merged
dibarbet merged 3 commits intodotnet:mainfrom Dec 13, 2022
Merged
Move BasicBuild to new integration test framework and implement#65889dibarbet merged 3 commits intodotnet:mainfrom
dibarbet merged 3 commits intodotnet:mainfrom
Conversation
5 tasks
dibarbet
commented
Dec 13, 2022
| } | ||
|
|
||
| [IdeFact, Trait(Traits.Feature, Traits.Features.Build)] | ||
| public async Task BuildProject() |
Member
Author
There was a problem hiding this comment.
implemented the same as the C# version
jasonmalinowski
approved these changes
Dec 13, 2022
|
|
||
| VisualStudio.Editor.SetText(editorText); | ||
|
|
||
| // TODO: Validate build works as expected |
ghost
added this to the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The csharp version is already moved. I noticed this one wasn't and didn't actually test anything, so I implemented it to have the same behavior as the csharp version.