Only used cached remote-host-provider for preview workspace if it shares the same set of host-services.#67840
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Apr 18, 2023
Conversation
ghost
added
Area-IDE
untriaged
Contributor
Author
|
@genlu ptal :) |
genlu
approved these changes
Apr 18, 2023
Member
genlu
left a comment
genlu
left a comment
There was a problem hiding this comment.
The change looks fine to me. But I don't really understand how this works, so take my approval for what it's worth :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed assert i hit when opening up tools|options. Tools|Options gets its own PreviewWorkspace not attached to the vs one.