Update ICSharpCode.Decompiler to 7.2.1.6856#67875
Merged
CyrusNajmabadi merged 7 commits intodotnet:mainfrom Apr 20, 2023
Merged
Update ICSharpCode.Decompiler to 7.2.1.6856#67875CyrusNajmabadi merged 7 commits intodotnet:mainfrom
CyrusNajmabadi merged 7 commits intodotnet:mainfrom
Conversation
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 19, 2023
| <MicrosoftMetadataVisualizerVersion>1.0.0-beta3.21075.2</MicrosoftMetadataVisualizerVersion> | ||
| <MicrosoftNETBuildExtensionsVersion>2.2.101</MicrosoftNETBuildExtensionsVersion> | ||
| <MicrosoftNETCorePlatformsVersion>2.1.2</MicrosoftNETCorePlatformsVersion> | ||
| <MicrosoftNETCorePlatformsVersion>5.0.0</MicrosoftNETCorePlatformsVersion> |
Contributor
Author
There was a problem hiding this comment.
@dotnet/roslyn-infrastructure any issues with this? It was required for the new ICSharpCodeDecompiler version. It also matches the line below which makes me feel like it's likely ok :D
There was a problem hiding this comment.
LGTM! @dibarbet fyi to flag the insertion, if there are issues.
arunchndr
approved these changes
Apr 19, 2023
| <MicrosoftMetadataVisualizerVersion>1.0.0-beta3.21075.2</MicrosoftMetadataVisualizerVersion> | ||
| <MicrosoftNETBuildExtensionsVersion>2.2.101</MicrosoftNETBuildExtensionsVersion> | ||
| <MicrosoftNETCorePlatformsVersion>2.1.2</MicrosoftNETCorePlatformsVersion> | ||
| <MicrosoftNETCorePlatformsVersion>5.0.0</MicrosoftNETCorePlatformsVersion> |
There was a problem hiding this comment.
LGTM! @dibarbet fyi to flag the insertion, if there are issues.
dibarbet
approved these changes
Apr 19, 2023
Contributor
Author
|
Tests are failing because of baselines:
|
CyrusNajmabadi
commented
Apr 19, 2023
| { | ||
| // Method begins at RVA 0x207f | ||
| // Code size 7 (0x7) | ||
| // Code size: 7 (0x7) |
Contributor
Author
There was a problem hiding this comment.
Mechanical change.
Contributor
Author
|
@dotnet/roslyn-compiler ptal. |
Contributor
Author
|
@jaredpar ptal at the compiler side. thanks! |
jcouv
approved these changes
Apr 20, 2023
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
Compiler changes (test-only) LGTM Thanks (iteration 7)
jcouv
added
Area-Compilers
and removed
untriaged
5 tasks
dibarbet
added a commit
to dibarbet/roslyn
that referenced
this pull request
Apr 21, 2023
This reverts commit 78a7616.
dibarbet
added a commit
that referenced
this pull request
Apr 21, 2023
Revert "Update ICSharpCode.Decompiler to 7.2.1.6856 (#67875)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OOM when decompiling code with large byte[]s.