Move tests down from editor features to features layer.#67883
Merged
CyrusNajmabadi merged 41 commits intodotnet:mainfrom Apr 20, 2023
Merged
Move tests down from editor features to features layer.#67883CyrusNajmabadi merged 41 commits intodotnet:mainfrom
CyrusNajmabadi merged 41 commits intodotnet:mainfrom
Conversation
ghost
added
Area-IDE
untriaged
dibarbet
approved these changes
Apr 20, 2023
Member
dibarbet
left a comment
dibarbet
left a comment
There was a problem hiding this comment.
Only really looked in-depth on the actual modified files
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Compile Include="..\..\Analyzers\CSharp\Tests\UseVarTestExtensions.cs" Link="CodeRefactorings\UseVarTestExtensions.cs" /> | ||
| <Compile Include="..\..\Features\CSharpTest\CodeActions\AbstractCSharpCodeActionTest.cs" Link="CodeActions\AbstractCSharpCodeActionTest.cs" /> |
Member
There was a problem hiding this comment.
do the rest of the tests implementing AbstractCSharpCodeActionTest in editorfeatures make use of actual editor packages? Or are you planning on moving those down later as well (similar q for the other linked files)
Contributor
Author
There was a problem hiding this comment.
tehre are currently code-actions that are EditorFeatures specific today (they do use things like accessing the paste service).
Member
|
Is this expected to mitigate some of the behavior seen in #67864? |
Contributor
Author
|
@RikkiGibson it might help there. This is mostly to help with the long test discover times I get locally :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.