Skip to content

Enable document outline by default#68088

Merged
sharwell merged 3 commits intodotnet:mainfrom
sharwell:document-outline
May 15, 2023
Merged

Enable document outline by default#68088
sharwell merged 3 commits intodotnet:mainfrom
sharwell:document-outline

Conversation

@sharwell
Copy link
Copy Markdown
Contributor

@sharwell sharwell commented May 4, 2023

Closes #68192
Closes AB#1715901

@sharwell sharwell requested a review from a team as a code owner May 4, 2023 14:25
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 4, 2023
@sharwell sharwell enabled auto-merge May 4, 2023 14:25
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

I don't believe DOcument Outline to be in a ready state yet. #67264 tracks what i think is necessary to get to a min-bar level of quality where this could be on by default.

@sharwell sharwell disabled auto-merge May 4, 2023 16:28
@sharwell sharwell marked this pull request as draft May 4, 2023 16:28
@sharwell
Copy link
Copy Markdown
Contributor Author

sharwell commented May 4, 2023

@CyrusNajmabadi Do I have approval to merge this once #68094 merges?

@sharwell sharwell marked this pull request as ready for review May 4, 2023 23:00
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

No :)

Primarily because you fixed a bunch of other issues. So i'd like to review that and then do a sign off again. I want to understand how certain things work there. But i will prioritize this review.

@sharwell sharwell force-pushed the document-outline branch from 9346920 to 003d282 Compare May 15, 2023 16:51
@sharwell sharwell force-pushed the document-outline branch from 003d282 to 789f18b Compare May 15, 2023 17:00
@sharwell sharwell enabled auto-merge May 15, 2023 19:46
@sharwell sharwell merged commit 69f87c6 into dotnet:main May 15, 2023
@ghost ghost added this to the Next milestone May 15, 2023
@sharwell sharwell deleted the document-outline branch May 16, 2023 02:11
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need Feature/AB flag for Document-Outline.

3 participants