Skip to content

Merge main into features/RefReadonly#68486

Merged
jjonescz merged 503 commits intodotnet:features/RefReadonlyfrom
jjonescz:RefReadonly-main
Jun 8, 2023
Merged

Merge main into features/RefReadonly#68486
jjonescz merged 503 commits intodotnet:features/RefReadonlyfrom
jjonescz:RefReadonly-main

Conversation

@jjonescz
Copy link
Copy Markdown
Member

@jjonescz jjonescz commented Jun 8, 2023

No conflicts.

Cosifne and others added 30 commits May 10, 2023 17:29
…ptionsChange

Add RequiresNonDocumentChangesTag to ProjectOptionsChangeAction
…med-types and methods. (dotnet#68131)

* Use a singleton for empty type-parameters for named types

* move type parameters down

* Optimize methods as well

* Always create indirection

* Move type

* Apply suggestions from code review

* speeling

* nrt

* Inline

* Simplify

* Change to abstract override
…-release/dev17.5-vs-deps

Merge release/dev17.4 to release/dev17.5-vs-deps
* Record added node output states as new

The `(EntryState.Modified, EntryState.Added) => IncrementalStepRunReason.Modified` state mapping was recently added in dotnet#61308, but doesn't look correct to me. Since this value is used as the output status, and the outputs are new, I believe the correct state should be `IncrementalStepRunReason.New` instead.

* Update tests that were added since I originally implemented the change

* Update documentation for IncrementalStepRunReason

* Update VB tests also

* Add note about breaking changes with IncrementalStepRunReason

---------

Co-authored-by: Jan Jones <janjones@microsoft.com>
* Add a test

* Display standalone parameter names by default

* Document breaking change

* Update tests
Avoid rooting document instances in NavigateToSearchResult
Deprecate CompilationWithAnalyzers.IsDiagnosticAnalyzerSuppressed public API
Avoid waiting on the thread pool when there is no work to do
Use a proper tool bar in Document Outline
Fix detection of nested symbols in Document Outline
@jjonescz jjonescz added the Feature - Ref Readonly Parameters `ref readonly` parameters label Jun 8, 2023
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 8, 2023
@jjonescz jjonescz marked this pull request as ready for review June 8, 2023 08:10
@jjonescz jjonescz requested review from a team, 333fred and dibarbet as code owners June 8, 2023 08:10
@jjonescz jjonescz requested a review from a team June 8, 2023 08:10
@jjonescz jjonescz requested a review from a team as a code owner June 8, 2023 08:10
@jjonescz jjonescz enabled auto-merge June 8, 2023 08:10
@jjonescz
Copy link
Copy Markdown
Member Author

jjonescz commented Jun 8, 2023

@dotnet/roslyn-compiler @jcouv @AlekseyTs need a sign-off on a clean merge

@jjonescz jjonescz merged commit 8ca7c0a into dotnet:features/RefReadonly Jun 8, 2023
@jjonescz jjonescz deleted the RefReadonly-main branch June 8, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure Feature - Ref Readonly Parameters `ref readonly` parameters untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.