Remove remaining ref readonly prototype comments#69082
Merged
jjonescz merged 3 commits intodotnet:features/RefReadonlyfrom Jul 19, 2023
Merged
Remove remaining ref readonly prototype comments#69082jjonescz merged 3 commits intodotnet:features/RefReadonlyfrom
ref readonly prototype comments#69082jjonescz merged 3 commits intodotnet:features/RefReadonlyfrom
Conversation
ghost
added
Area-Compilers
untriaged
jjonescz
commented
Jul 18, 2023
| { | ||
| // For symbols that are not defined in the same compilation (like NoPia), don't synthesize this attribute. | ||
| Debug.Assert(false); // PROTOTYPE: Test this code path. | ||
| Debug.Assert(false, $"Unexpected embedding of a parameter symbol '{symbol.ToDisplayString()}'"); |
Member
Author
There was a problem hiding this comment.
Don't think this path is reachable - only types are embedded in NoPIA scenarios, not parameters. #Closed
Contributor
There was a problem hiding this comment.
only types are embedded in NoPIA scenarios, not parameters.
That is not accurate. Interface methods are embedded and their parameters as well. We probably have a test that hits this code path in SynthesizeIsReadOnlyAttribute
Member
Author
There was a problem hiding this comment.
You're right, thanks, adding a test.
cston
approved these changes
Jul 18, 2023
Contributor
|
Done with review pass (commit 1) |
AlekseyTs
approved these changes
Jul 19, 2023
Contributor
AlekseyTs
left a comment
AlekseyTs
left a comment
There was a problem hiding this comment.
LGTM (commit 2), assuming CI is passing
cston
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan: #68056