Enable bootstrapped builds in VS test insertion YAML

[jcouv]

In order to get speedometer results on an experimental compiler codegen change, we need to temporarily enable bootstrapping.

[333fred]

Talked with Julien offline about this, and I think I'm going to need a complete explanation of why this needs to be in a separate PR that will slow down all roslyn CI for several days.

[jcouv]

Sounds like we'll have to wait til @jaredpar is back, as I'm not able to provide sufficient details.

[jaredpar]

... why this needs to be in a separate PR that will slow down all roslyn CI for several days.

How will this slow down roslyn CI? This is the PR official pipeline file. To my understanding that is only used in the following pipeline which is run "on demand" only.

https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build?definitionId=8972&_a=summary

[333fred]

The file is named azure-pipelines-pr-validation.yml. If it's not actually for PR validation, maybe the file needs to be renamed.

[333fred]

I also am still unsure why this needs to be checked in. Why does the compiler itself need to be built with the flag?

[jcouv]

Why does the compiler itself need to be built with the flag?

We want a speedometer result of VS using roslyn bits using the new codegen.
Bootstrapping is what will cause the roslyn bits to use the new codegen. Without bootstrapping, the roslyn bits would still use the old async codegen.

[333fred]

We want a speedometer result of VS using roslyn bits using the new codegen.
Bootstrapping is what will cause the roslyn bits to use the new codegen. Without bootstrapping, the roslyn bits would still use the old async codegen.

Thanks. This, and that the file was not standard ci, were the pieces that I was missing.

[jcouv]

@jaredpar for review. Thanks

[jaredpar]

The file is named azure-pipelines-pr-validation.yml. If it's not actually for PR validation, maybe the file needs to be renamed.

I agree the name is confusing and I wish there we had a better one. I'm fine with renaming if @dibarbet agrees.

[dibarbet]

The file is named azure-pipelines-pr-validation.yml. If it's not actually for PR validation, maybe the file needs to be renamed.

I agree the name is confusing and I wish there we had a better one. I'm fine with renaming if @dibarbet agrees.

I'm fine with renaming, but the pipeline is specifically for validating PRs (against VS). Maybe something like azure-pipelines-test-insertion or something? I'll trust you all to come up with something good :)

[jcouv]

I'm not planning to rename in this PR (not the intent, I'm just trying to unblock validation of a codegen change), that can be a follow-up.
@jaredpar for a second look. Thanks

[jaredpar]

Yeah I don't want to change the name here. Just saying it's fine for another PR.