Update Concord dependency versions and fix nullability warnings#69195
Merged
tmat merged 1 commit intodotnet:mainfrom Jul 27, 2023
Merged
Update Concord dependency versions and fix nullability warnings#69195tmat merged 1 commit intodotnet:mainfrom
tmat merged 1 commit intodotnet:mainfrom
Conversation
Contributor
chuckries
commented
Jul 24, 2023
chuckries
commented
- Update Concord dependency versions to pull in their latest APIs which are required for future changes.
- Concord has increased its surface area of nullable reference types, resolve the warnings created by the new nullable references types in Concord APIs
ghost
added
Area-Interactive
untriaged
Contributor
Author
isadorasophia
approved these changes
Jul 24, 2023
chuckries
force-pushed
the
dev/chuckr/UpdateConcordDeps
branch
from
e49b256 to
80bbe39
Compare
gregg-miskelly
approved these changes
Jul 25, 2023
tmat
reviewed
Jul 25, 2023
src/ExpressionEvaluator/Core/Source/ExpressionCompiler/FrameDecoder.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jul 25, 2023
src/ExpressionEvaluator/Core/Source/ExpressionCompiler/ExpressionCompiler.cs
Outdated
Show resolved
Hide resolved
chuckries
force-pushed
the
dev/chuckr/UpdateConcordDeps
branch
from
80bbe39 to
093f990
Compare
Contributor
Author
|
@tmat I believe this is ready to merge |
chuckries
force-pushed
the
dev/chuckr/UpdateConcordDeps
branch
from
093f990 to
f330714
Compare
Contributor
|
@dotnet/roslyn-infrastructure this may require a vs-deps branch |
sharwell
reviewed
Jul 26, 2023
src/ExpressionEvaluator/Core/Source/ExpressionCompiler/ExpressionCompiler.cs
Outdated
Show resolved
Hide resolved
- Update Concord dependency versions to pull in their latest APIs which are required for future changes. - Concord has increased its surface area of nullable reference types, resolve the warnings created by the new nullable references types in Concord APIs
chuckries
force-pushed
the
dev/chuckr/UpdateConcordDeps
branch
from
f330714 to
cae9294
Compare
tmat
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.