Fix ref readonly mismatch retargeting#69205
Merged
jjonescz merged 1 commit intodotnet:mainfrom Jul 28, 2023
Merged
Conversation
jjonescz
added
Area-Compilers
Feature - Ref Readonly Parameters
ghost
added
the
untriaged
AlekseyTs
approved these changes
Jul 25, 2023
Contributor
AlekseyTs
left a comment
AlekseyTs
left a comment
There was a problem hiding this comment.
LGTM (commit 1), assuming CI is passing
Member
Author
|
@jcouv for a second review, thanks |
jcouv
removed
the
untriaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #68680 (comment).
Without allowing mismatch the new test would fail for
emit = false, i.e., PE and retargeting scenarios would be inconsistent.Test plan: #68056