Allow File-local type to shadow a namespace declaration in a different file#69254
Merged
RikkiGibson merged 3 commits intodotnet:mainfrom Jul 28, 2023
Merged
Conversation
ghost
added
Area-Compilers
untriaged
RikkiGibson
force-pushed
the
file-type-shadow-namespace
branch
from
d57cc53 to
3a4d110
Compare
cston
reviewed
Jul 28, 2023
cston
reviewed
Jul 28, 2023
| // (3,16): error CS9071: The namespace 'App' already contains a definition for 'Widget' in this file. | ||
| // file class Widget { } | ||
| Diagnostic(ErrorCode.ERR_FileLocalDuplicateNameInNS, "Widget").WithArguments("Widget", "App").WithLocation(3, 16)); | ||
| } |
Contributor
cston
approved these changes
Jul 28, 2023
jcouv
reviewed
Jul 28, 2023
src/Compilers/CSharp/Portable/Symbols/Source/SourceNamespaceSymbol.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Jul 28, 2023
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (iteration 1). Only minor comment to consider
cston
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68429