Remove positive Unary expressions to avoid confusion in addition#69257
Merged
jaredpar merged 1 commit intodotnet:mainfrom Aug 9, 2023
Merged
Remove positive Unary expressions to avoid confusion in addition#69257jaredpar merged 1 commit intodotnet:mainfrom
jaredpar merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
Area-Compilers
untriaged
jcouv
added
Test
dibarbet
added a commit
to dibarbet/roslyn
that referenced
this pull request
Aug 15, 2023
…ion (dotnet#69257)" This reverts commit 09d8554.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small cleanup to avoid having problems when updating this code. I think adding an analyzer to detect positive unary expressions in an addition expression would be helpful for others too.