Skip to content

Consistently use UICulture instead of Culture#69305

Merged
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:fix_lsp_culture
Aug 1, 2023
Merged

Consistently use UICulture instead of Culture#69305
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:fix_lsp_culture

Conversation

@dibarbet
Copy link
Copy Markdown
Member

@dibarbet dibarbet commented Aug 1, 2023

I messed this up in the original PR - we were setting the CurrentUICulture (correct), but reading the fallback from CurrentCulture. Fixed to also read from CurrentUICulture

@dibarbet dibarbet requested a review from a team as a code owner August 1, 2023 00:41
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 1, 2023
@dibarbet dibarbet enabled auto-merge August 1, 2023 01:00
@dibarbet dibarbet merged commit 4f5128d into dotnet:main Aug 1, 2023
@ghost ghost added this to the Next milestone Aug 1, 2023
@dibarbet dibarbet deleted the fix_lsp_culture branch August 1, 2023 18:35
@dibarbet dibarbet modified the milestones: Next, 17.8 P2 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants