Suppress ref readonly warnings for collection initializers#69307
Merged
jjonescz merged 2 commits intodotnet:mainfrom Aug 10, 2023
Merged
Suppress ref readonly warnings for collection initializers#69307jjonescz merged 2 commits intodotnet:mainfrom
ref readonly warnings for collection initializers#69307jjonescz merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
Area-Compilers
untriaged
jjonescz
commented
Aug 1, 2023
| Debug.Assert(addMethod.Parameters | ||
| .Skip(addMethod.IsExtensionMethod ? 1 : 0) | ||
| .All(p => p.RefKind == RefKind.None || p.RefKind == RefKind.In)); | ||
| .All(p => p.RefKind is RefKind.None or RefKind.In or RefKind.RefReadOnlyParameter)); |
Member
Author
There was a problem hiding this comment.
Note that this change is already included in parallel PR 8beb44d.
jcouv
removed
the
untriaged
Member
Author
|
@dotnet/roslyn-compiler for a second review, thanks |
jaredpar
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by similar changes for interpolated string handlers and extension method receivers.
Speclet change: dotnet/csharplang@8e5c156
Test plan: #68056