Skip to content

Add link to ref readonly feature branch#69435

Merged
jjonescz merged 1 commit intodotnet:mainfrom
jjonescz:RefReadonly-25-FeatureBranch
Aug 9, 2023
Merged

Add link to ref readonly feature branch#69435
jjonescz merged 1 commit intodotnet:mainfrom
jjonescz:RefReadonly-25-FeatureBranch

Conversation

@jjonescz
Copy link
Copy Markdown
Member

@jjonescz jjonescz commented Aug 9, 2023

Forgot to do this in #69240.

@jjonescz jjonescz requested a review from jcouv August 9, 2023 07:39
@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 9, 2023
| Feature | Branch | State | Developer | Reviewer | LDM Champ |
| ------- | ------ | ----- | --------- | -------- | --------- |
| [ref readonly parameters](https://github.com/dotnet/csharplang/issues/6010) | main | [Merged into 17.8p2](https://github.com/dotnet/roslyn/issues/68056) | [jjonescz](https://github.com/jjonescz) | [jcouv](https://github.com/jcouv), [AlekseyTs](https://github.com/AlekseyTs) | [akhera99](https://github.com/akhera99) | [jaredpar](https://github.com/jaredpar)
| [ref readonly parameters](https://github.com/dotnet/csharplang/issues/6010) | [RefReadonly](https://github.com/dotnet/roslyn/tree/features/RefReadonly) | [Merged into 17.8p2](https://github.com/dotnet/roslyn/issues/68056) | [jjonescz](https://github.com/jjonescz) | [jcouv](https://github.com/jcouv), [AlekseyTs](https://github.com/AlekseyTs) | [akhera99](https://github.com/akhera99) | [jaredpar](https://github.com/jaredpar)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: FWIW, I don't think we care about this column much after the feature was merged. Some people even suggested we should put main at that point. I'm fine to leave the feature branch for posterity, even though we'll delete the feature branch sometime :-)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should put main at that point

That's what I thought at first, but it seems that feature branches are not deleted (or at least not very often?).

@jjonescz jjonescz merged commit b1afd52 into dotnet:main Aug 9, 2023
@jjonescz jjonescz deleted the RefReadonly-25-FeatureBranch branch August 9, 2023 15:55
@ghost ghost added this to the Next milestone Aug 9, 2023
@dibarbet dibarbet modified the milestones: Next, 17.8 P2 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants