Print diagnostics in invariant culture (English error messages) in assert text#72816
Merged
AlekseyTs merged 1 commit intodotnet:mainfrom Apr 2, 2024
DoctorKrolic:invariant-assert-text
Merged
Print diagnostics in invariant culture (English error messages) in assert text#72816AlekseyTs merged 1 commit intodotnet:mainfrom DoctorKrolic:invariant-assert-text
AlekseyTs merged 1 commit intodotnet:mainfrom
DoctorKrolic:invariant-assert-text
Conversation
ghost
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
Member
|
This seems reasonable to me but wanted to get @AlekseyTs take as he designed our locale strategy for testing |
Contributor
|
@DoctorKrolic Thanks for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assert text is only used when test fails to show expected vs actual diagnostics. Printing them with English messages won't break any culture-specific tests, but bring 2 positive changes: