Suggest where keyword in generic local function declarations#72838
Merged
sharwell merged 4 commits intodotnet:mainfrom Apr 2, 2024
Merged
Suggest where keyword in generic local function declarations#72838sharwell merged 4 commits intodotnet:mainfrom
where keyword in generic local function declarations#72838sharwell merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
Contributor
Public APIs need to go through API review process first. You cannot just add public API to simplify your IDE fix as you go |
sharwell
suggested changes
Apr 2, 2024
Contributor
sharwell
left a comment
sharwell
left a comment
There was a problem hiding this comment.
Need to remove the Arity property and inline the computed value where it was used.
Contributor
Author
|
@sharwell removed the public API, ptal |
sharwell
reviewed
Apr 2, 2024
src/Features/CSharp/Portable/Completion/KeywordRecommenders/WhereKeywordRecommender.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Apr 2, 2024
3 tasks
Contributor
Author
|
@sharwell can you please rerun the checks that crashed? |
src/Features/CSharp/Portable/Completion/KeywordRecommenders/WhereKeywordRecommender.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest2/Recommendations/WhereKeywordRecommenderTests.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest2/Recommendations/WhereKeywordRecommenderTests.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest2/Recommendations/WhereKeywordRecommenderTests.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Apr 2, 2024
Contributor
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
lgtm with suggestions.
Co-Authored-By: Cyrus Najmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
auto-merge was automatically disabled
April 2, 2024 16:01
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72821