Remove ability for a project to change its language#72847
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Apr 2, 2024
Merged
Remove ability for a project to change its language#72847CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
Area-IDE
untriaged
This was referenced Apr 13, 2024
Contributor
Author
|
@jasonmalinowski For review when you get back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wasn't something that actually was possible or made sense (since hte underlying 'ProjectAttribute' value doesn't even support this). No codepaths use this eitehr. Removing as it removed a potential very strange case from having to be handled in some of the source-generator code i was writing. Specifically if the project chnaged from a lang supporting generators to one that didn't. This change makes it so that literally isn't even possible to try to do :)