Merged
Conversation
sharwell
suggested changes
Apr 2, 2024
Contributor
sharwell
left a comment
There was a problem hiding this comment.
Marking time for review
sharwell
approved these changes
Apr 2, 2024
This was referenced Apr 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Chat didn't have access to latest Roslyn (therefore our EA assembly,) so we have to allow default here and use a reflection based fallback so relevant features would work with older chat extension.
Once chat extension caught up, we will be able to mark this required and remove all reflection stuff.