Skip to content

Fix MEF import of to allow null#72851

Merged
genlu merged 1 commit intodotnet:mainfrom
genlu:FixMefImport
Apr 2, 2024
Merged

Fix MEF import of to allow null#72851
genlu merged 1 commit intodotnet:mainfrom
genlu:FixMefImport

Conversation

@genlu
Copy link
Member

@genlu genlu commented Apr 2, 2024

Copilot Chat didn't have access to latest Roslyn (therefore our EA assembly,) so we have to allow default here and use a reflection based fallback so relevant features would work with older chat extension.

Once chat extension caught up, we will be able to mark this required and remove all reflection stuff.

@genlu genlu requested a review from a team as a code owner April 2, 2024 21:23
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 2, 2024
Copy link
Contributor

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking time for review

@genlu genlu enabled auto-merge April 2, 2024 21:36
@genlu genlu merged commit fe6fd82 into dotnet:main Apr 2, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 2, 2024
@genlu genlu deleted the FixMefImport branch April 3, 2024 00:39
@dibarbet dibarbet modified the milestones: Next, 17.11 P1 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants