Remove less individual sync calls to get compilation options.#72951
Merged
CyrusNajmabadi merged 6 commits intodotnet:mainfrom Apr 10, 2024
Merged
Remove less individual sync calls to get compilation options.#72951CyrusNajmabadi merged 6 commits intodotnet:mainfrom
CyrusNajmabadi merged 6 commits intodotnet:mainfrom
Conversation
ghost
added
Area-IDE
untriaged
Contributor
Author
|
@ToddGrun ptal. |
ToddGrun
reviewed
Apr 9, 2024
| projectInfoChecksums.Add(newProjectChecksums.Info); | ||
| // Note: it's common to need to collect a large set of project-attributes and compilation options. So | ||
| // attempt to collect all of those in a single call for each kind instead of a call for each instance | ||
| // needed. |
Contributor
There was a problem hiding this comment.
This code only really needs to execute on changed projects, rignt? If so, could we move this code down there and have it only work on checksums from those projects?
Contributor
Author
There was a problem hiding this comment.
changed and added projects. which is precisely what is in newProjectIdToStateChecksums.
This was referenced Apr 13, 2024
Contributor
Author
|
@jasonmalinowski For review when you get back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #72930.
before, we make nearly 400 calls to get compilation options:
After, it's just 8: