Improve go-to-impl and inheritance margin with error conditions#75913
Merged
CyrusNajmabadi merged 6 commits intodotnet:mainfrom Nov 14, 2024
Merged
Improve go-to-impl and inheritance margin with error conditions#75913CyrusNajmabadi merged 6 commits intodotnet:mainfrom
CyrusNajmabadi merged 6 commits intodotnet:mainfrom
Conversation
ghost
added
Area-IDE
untriaged
Contributor
Author
|
@dibarbet ptal. This applies similar logic to 'go to impl' and 'inheritance margin' so that we can find these cases where overrides don't match. This is def nice because it addresses a core problem where you change some abstract base member, and then want to find all the overrides to fix them up. |
dibarbet
approved these changes
Nov 14, 2024
This was referenced Nov 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #75901