Don't show Razor diagnostics in Full Solution Analysis#80296
Merged
davidwengier merged 3 commits intodotnet:mainfrom Sep 16, 2025
Merged
Don't show Razor diagnostics in Full Solution Analysis#80296davidwengier merged 3 commits intodotnet:mainfrom
davidwengier merged 3 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
approved these changes
Sep 16, 2025
Contributor
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Seems reasonable. perhaps a test somewhere?
.../Protocol/Handler/Diagnostics/DiagnosticSources/AbstractWorkspaceDocumentDiagnosticSource.cs
Outdated
Show resolved
Hide resolved
davidwengier
commented
Sep 16, 2025
.../Protocol/Handler/Diagnostics/DiagnosticSources/AbstractWorkspaceDocumentDiagnosticSource.cs
Outdated
Show resolved
Hide resolved
…ces/AbstractWorkspaceDocumentDiagnosticSource.cs
davidwengier
commented
Sep 16, 2025
.../Protocol/Handler/Diagnostics/DiagnosticSources/AbstractWorkspaceDocumentDiagnosticSource.cs
Outdated
Show resolved
Hide resolved
…ces/AbstractWorkspaceDocumentDiagnosticSource.cs
JoeRobich
approved these changes
Sep 16, 2025
This was referenced Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: microsoft/vscode-dotnettools#1941
The LSP editor did strange things with client names in order to not report diagnostics at all, but for cohosting that doesn't work as we want diagnostics when Razor calls to get them, so filtering out specifically in FullSolutionAnalysisDiagnosticSource seemed appropriate.