-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Closed
Copy link
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIarm-sveWork related to arm64 SVE/SVE2 supportWork related to arm64 SVE/SVE2 support
Milestone
Description
Today, for ConditionalSelect, we will just eliminate trueValue , if we see the mask is AllZero.
runtime/src/coreclr/jit/hwintrinsic.cpp
Lines 1912 to 1915 in 1830cf0
| else if (op1->IsVectorZero()) | |
| { | |
| return retNode->AsHWIntrinsic()->Op(3); | |
| } |
This will fail if trueValue has a side-effect or a method call.
https://godbolt.org/z/qbbYenW9j
Thanks @TIHan for bringing it to attention.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIarm-sveWork related to arm64 SVE/SVE2 supportWork related to arm64 SVE/SVE2 support