Merged
Conversation
Member
Author
Member
Author
Member
Author
Member
Author
|
@jkotas PTAL |
jkotas
reviewed
May 2, 2024
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunConstants.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@jakobbotsch cc @dotnet/jit-contrib PTAL jit part, |
jakobbotsch
reviewed
May 3, 2024
jakobbotsch
reviewed
May 3, 2024
Comment on lines
+8239
to
+8244
| if (data->OperIs(GT_IND)) | ||
| { | ||
| // Drop GT_IND nodes | ||
| BlockRange().Remove(data); | ||
| data = data->AsIndir()->Addr(); | ||
| } |
Member
There was a problem hiding this comment.
Do we need to worry about any indir flags here, like GTF_IND_VOLATILE?
Member
Author
There was a problem hiding this comment.
Good question, I think it's safer to just give up on those here, fixed.
jakobbotsch
approved these changes
May 3, 2024
Member
Author
This was referenced May 3, 2024
System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker Test failure
#96407
Closed
Member
Author
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101699
Closes #8627
Use a bulk copy when we need to copy a struct with gc fields (non-null) instead of individual gc write barriers