[release/8.0-staging] Remove cached cgroup values (#102971)#103166
Merged
cshung merged 1 commit intodotnet:release/8.0-stagingfrom Jun 10, 2024
Merged
[release/8.0-staging] Remove cached cgroup values (#102971)#103166cshung merged 1 commit intodotnet:release/8.0-stagingfrom
cshung merged 1 commit intodotnet:release/8.0-stagingfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/gc |
|
Hi folks, just want to mention that I'm keen for this backport! Azure Functions intends to use this refresh API to allow us to serve requests for applications with different memory size limits from the same pool of pre-allocated .NET 8 processes, reducing the COGS overhead of these pools. |
cshung
changed the title
mangod9
approved these changes
Jun 7, 2024
jeffschwMSFT
approved these changes
Jun 8, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 8.0.x
Contributor
|
FYI Today's code complete for the July Release in case you were intending to get it approved and merged today. The branch closes at 4pm PT. |
jeffschwMSFT
added
Servicing-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main PR #102971
Description
Make sure we do not rely on cached cgroup when we
RefreshMemoryLimit.Customer Impact
See the comments from @paulbatum below.
Regression
No
Testing
Manual validation of the
RefreshMemoryLimitscenario when the underlying container changes.Risk
Low - it only impacts the case when
RefreshMemoryLimitis called.