Merged
Conversation
ghost
added
the
Member
Author
|
changes in gc.h are temporary and will be reverted. |
This was referenced Jun 17, 2024
markples
approved these changes
Jun 17, 2024
cshung
approved these changes
Jun 17, 2024
| temp_change = 0x0020 | ||
| }; | ||
|
|
||
| bool should_change (float tcp, float* tcp_to_consider, size_t current_gc_index, |
Contributor
There was a problem hiding this comment.
Is there a reason why we put the implementation of all these functions in the header file?
Member
Author
There was a problem hiding this comment.
just a personal choice, I found it easier to look at them side by side (so have gcpriv.h in one window and gc.cpp with the callersites in a different window) since I often look at them together. it's easier than having to scroll around in one file.
markples
reviewed
Jun 17, 2024
Member
Author
|
reverted the white space only changes. |
markples
reviewed
Jun 17, 2024
| dec_multiple = 0x0004, | ||
| fluctuation = 0x0008 | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
can remove the clutter from the code with something like
inline hc_change_freq_reason operator| (hc_change_freq_reason _a, hc_change_freq_reason _b) {
return static_cast<hc_change_freq_reason>(static_cast<int>(_a) | static_cast<int>(_b));
}
This was referenced Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since we want to enable this, I needed to add necessary diag info in the events.
will be doing some testing later today.