Skip to content

Extend RunClassConstructor intrinsic handling to accept NonPublicConstructors#103947

Merged
MichalStrehovsky merged 2 commits intodotnet:mainfrom
MichalStrehovsky:analyzeruncctor
Jun 26, 2024
Merged

Extend RunClassConstructor intrinsic handling to accept NonPublicConstructors#103947
MichalStrehovsky merged 2 commits intodotnet:mainfrom
MichalStrehovsky:analyzeruncctor

Conversation

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Jun 25, 2024

This should not generate a warning since the static constructor will be kept.

This also requires #103946 to be correct on native AOT side.

Fixes #103679.

Cc @dotnet/illink

…tructors

This should not generate a warning since the static constructor will be kept.
@MichalStrehovsky MichalStrehovsky requested a review from sbomer June 25, 2024 07:46
@ghost ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jun 25, 2024
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Jun 25, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichalStrehovsky MichalStrehovsky merged commit eb29166 into dotnet:main Jun 26, 2024
@MichalStrehovsky MichalStrehovsky deleted the analyzeruncctor branch June 26, 2024 05:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Proposal]: trim-safe RuntimeHelpers.RunClassConstructor(Type) overload

2 participants