Skip to content

increase the allocation threshold for tests that need to ensure that 2GB+ does not get pre-allocated #104151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 2 commits into from
Jun 29, 2024
Merged

increase the allocation threshold for tests that need to ensure that 2GB+ does not get pre-allocated #104151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d816826
increase the allocation threshold for tests that need to ensure that …
adamsitnik Jun 28, 2024
3a56309
address code review feedback
adamsitnik Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/libraries/System.Formats.Nrbf/tests/AttackTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,15 @@ public void CyclicClassReferencesInArraysOfTDoNotCauseStackOverflow()
}

#if !NETFRAMEWORK
// The tests need to ensure that 2GB+ does not get pre-allocated.
// 200k is enough to get the job done and avoid getting false positives.
const long AllocationThreshold = 200_000;

// GC.GetAllocatedBytesForCurrentThread() is not available on Full Framework.
// AppDomain.CurrentDomain.MonitoringTotalAllocatedMemorySize is available,
// but it reports allocations for all threads. Using this API would require
// ensuring that it's the only test that is being run at a time.
// Mono either allocates more than expected or the API is not precise enough
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
[Fact]
public void ArraysOfStringsAreNotBeingPreAllocated()
{
using MemoryStream stream = new();
Expand All @@ -136,7 +139,7 @@ public void ArraysOfStringsAreNotBeingPreAllocated()

long after = GetAllocatedByteCount();

Assert.InRange(after, before, before + 5000);
Assert.InRange(after, before, before + AllocationThreshold);
Assert.Equal(SerializationRecordType.ArraySingleString, serializationRecord.RecordType);
}

Expand All @@ -162,7 +165,7 @@ public void ArraysOfBytesAreNotBeingPreAllocated()

long after = GetAllocatedByteCount();

Assert.InRange(after, before, before + 200_000);
Assert.InRange(after, before, before + AllocationThreshold);
}

private static long GetAllocatedByteCount()
Expand Down