[EventPipe] Handle EventPipe Enable calls during shutdown#105842
Merged
mdh1418 merged 1 commit intodotnet:mainfrom Aug 6, 2024
Merged
[EventPipe] Handle EventPipe Enable calls during shutdown#105842mdh1418 merged 1 commit intodotnet:mainfrom
mdh1418 merged 1 commit intodotnet:mainfrom
Conversation
Member
Author
|
I'm wondering, would there be another way to detect shutdown and avoid attempting to enable the eventpipe session? Would guarding |
This was referenced Aug 1, 2024
Closed
noahfalk
approved these changes
Aug 5, 2024
Member
There was a problem hiding this comment.
LGTM
There is still some remaining fishy behavior shown in #103480 that would be good to address in other PRs.
- The crash that occurs when the EventListener is not disposed
- We called EventListener.DisableEvents() but somehow that is being translated into a call to EventPipeInternal.Enable().
tommcdon
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103480