Reapply "Refactor external_assembly_probe to be separate from single-file bundle probing"#113776
Merged
elinor-fung merged 2 commits intodotnet:mainfrom Mar 25, 2025
Merged
Conversation
ghost
added
the
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 22 changed files in this pull request and generated no comments.
Files not reviewed (20)
- src/coreclr/binder/assemblybindercommon.cpp: Language not supported
- src/coreclr/binder/inc/assembly.hpp: Language not supported
- src/coreclr/binder/inc/assemblybindercommon.hpp: Language not supported
- src/coreclr/dlls/mscoree/exports.cpp: Language not supported
- src/coreclr/inc/assemblyprobeextension.h: Language not supported
- src/coreclr/inc/bundle.h: Language not supported
- src/coreclr/inc/hostinformation.h: Language not supported
- src/coreclr/vm/CMakeLists.txt: Language not supported
- src/coreclr/vm/assemblynative.cpp: Language not supported
- src/coreclr/vm/assemblyprobeextension.cpp: Language not supported
- src/coreclr/vm/assemblyspec.cpp: Language not supported
- src/coreclr/vm/bundle.cpp: Language not supported
- src/coreclr/vm/coreassemblyspec.cpp: Language not supported
- src/coreclr/vm/hostinformation.cpp: Language not supported
- src/coreclr/vm/nativeimage.cpp: Language not supported
- src/coreclr/vm/peassembly.cpp: Language not supported
- src/coreclr/vm/peassembly.inl: Language not supported
- src/coreclr/vm/peimage.cpp: Language not supported
- src/coreclr/vm/peimage.h: Language not supported
- src/coreclr/vm/peimage.inl: Language not supported
Contributor
|
Tagging subscribers to this area: @mangod9 |
AaronRobinsonMSFT
approved these changes
Mar 22, 2025
Member
|
I've been running this change for the last 7 hours on the repro VM I used in dotnet/source-build#4952 (comment) and so far it hasn't failed 😄 |
Member
Author
|
Thanks, @akoeplinger! I did also run the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undo the revert in #113738
0d3c852 is the change on top of the original that should address dotnet/source-build#4952.
Make a copy of the host contract information on initialization instead of just operating on a pointer to the struct. This should address intermittent failures on shutdown where a thread is still running after
coreclr_shutdownhas completed and the actual contract struct provided by a host may be cleaned up. The assumption is that any function pointers provided on the host contract at initialization should remain valid for the process lifetime.