Do not try obtaining canonical dictionaries in VirtualDispatchCellGenericLookupResult
#123512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nericLookupResult`
Native AOT outerloop builds are broken:
```
Process terminated. Assertion failed.
!owningType.IsCanonicalSubtype(CanonicalFormKind.Any)
at System.Diagnostics.DebugProvider.Fail(String, String) + 0x37
at System.Diagnostics.Debug.Fail(String, String) + 0x49
at ILCompiler.DependencyAnalysis.TypeGenericDictionaryNode..ctor(TypeDesc, NodeFactory) + 0x4c
...
D:\a\_work\1\s\artifacts\bin\coreclr\windows.x64.Checked\build\Microsoft.NETCore.Native.targets(332,5): error MSB3073: The command ""D:\a\_work\1\s\artifacts\bin\coreclr\windows.x64.Checked\x64\ilc\\ilc" @"D:\a\_work\1\s\artifacts\obj\Microsoft.Extensions.Logging.Tests\Release\net11.0-windows\native\Microsoft.Extensions.Logging.Tests.ilc.rsp"" exited with code 57005. [D:\a\_work\1\s\src\libraries\Microsoft.Extensions.Logging\tests\Common\Microsoft.Extensions.Logging.Tests.csproj::TargetFramework=net11.0-windows]
```
This is because we're trying to obtain generic dictionaries of something in a canonical form from here. The callsite identifier parameter is not necessary when referencing from NonConcrete methods because we're not going to build an associated generic dictionary anyway.
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression introduced in PR #122012 that caused outerloop test failures. The issue manifested as an assertion failure when attempting to create generic dictionaries for canonical types.
Changes:
- Fixed
VirtualDispatchCellGenericLookupResult.GetTargetto avoid creating generic dictionaries for non-concrete instantiations - Added conditional logic to only create dictionary nodes when
isConcreteInstantiationis true
sbomer
reviewed
Jan 22, 2026
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/GenericLookupResult.cs
Show resolved
Hide resolved
This was referenced Jan 23, 2026
Open
sbomer
approved these changes
Jan 23, 2026
Member
sbomer
left a comment
sbomer
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking care of this!
Member
|
/ba-g remaining native aot failures are fixed by other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We broke outerloops in #122012. Looks like the outerloop run was already broken in that PR but nobody went over the results.
This is because we're trying to obtain generic dictionaries of something in a canonical form from here. The callsite identifier parameter is not necessary when referencing from NonConcrete methods because we're not going to build an associated generic dictionary anyway.