-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add test coverage for DateTime.ParseExact with different DateTimeStyles #123600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: stephentoub <[email protected]>
Co-authored-by: stephentoub <[email protected]>
Copilot
AI
changed the title
[WIP] Improve test coverage of DateTime ParseExact with different DateTimeStyles
Add test coverage for DateTime.ParseExact with different DateTimeStyles
Jan 25, 2026
stephentoub
approved these changes
Jan 25, 2026
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request enhances test coverage for DateTime.ParseExact with various DateTimeStyles values that previously had minimal or no coverage, addressing issue #25295 (originally corefx#27678).
Changes:
- Converted
InvalidDateTimeStylestest from a single[Fact]to a parameterized[Theory]with 4 test cases covering invalid style combinations - Added 9 new test cases to
ParseExact_ValidInput_Succeeds_MemberDatacovering RoundtripKind (3), AssumeLocal (2), NoCurrentDateDefault (2), and AllowInnerWhite (2)
tarekgh
approved these changes
Jan 25, 2026
Member
|
/ba-g timeouts |
This was referenced Jan 26, 2026
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves test coverage for
DateTime.ParseExactwithDateTimeStylesvalues that had minimal or no coverage, per corefx#27678.New test cases added to
ParseExact_ValidInput_Succeeds_MemberData:Expanded
InvalidDateTimeStylestest:Converted from
[Fact]to[Theory]with invalid style combinations:All 1356 DateTime tests pass.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.