Clarify compilation and testing requirements in copilot-instructions#123613
Merged
stephentoub merged 2 commits intomainfrom Jan 26, 2026
Merged
Clarify compilation and testing requirements in copilot-instructions#123613stephentoub merged 2 commits intomainfrom
stephentoub merged 2 commits intomainfrom
Conversation
Trying to make it more deterministically build before trying to test and commit.
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
jkotas
approved these changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens the compilation and testing requirements in the Copilot instructions to make the build and test process more deterministic before committing code changes.
Changes:
- Upgraded compilation and testing requirements from "SHOULD" to "MUST"
- Removed the exception that allowed skipping builds for comment-only changes
- Clarified that baseline builds must be completed before making changes and running tests
- Consolidated build and test instructions for Libraries component
- Corrected System.Private.CoreLib rebuild configuration from
-rc releaseto-rc checked - Removed separate build sections for CoreCLR and Mono components (keeping only test instructions)
Comments suppressed due to low confidence (3)
.github/copilot-instructions.md:101
- The removal of the explicit library build command
./build.sh libs -rc releasemay cause confusion. After the baseline build completes, developers working on library changes need a way to rebuild just the libraries without running tests. The current instructions only show how to build and test a specific library usingdotnet buildfrom within that library's directory, but don't provide a command to rebuild all libraries from the repo root after making changes. Consider retaining the./build.sh libs -rc releasecommand as a separate option for rebuilding all libraries.
This issue also appears in the following locations of the same file:
- line 113
- line 117
**Build and test a specific library:**
```bash
cd src/libraries/<LibraryName>
dotnet build
dotnet build /t:test ./tests/<TestProject>.csproj
**.github/copilot-instructions.md:113**
* The removal of the separate "Build" section for CoreCLR may cause issues. The baseline build (Step 2) for CoreCLR is `./build.sh clr+libs+host`, but after making code changes to CoreCLR, developers need a way to rebuild just the CoreCLR component without rebuilding libs and host. The original `./build.sh clr` command served this purpose. Without it, developers may waste time rebuilding unnecessary components or may not know the correct incremental build command. Consider retaining the build command for incremental rebuilds after the initial baseline.
Test: cd src/tests && ./build.sh && ./run.sh
**.github/copilot-instructions.md:123**
* The removal of the separate "Build" section for Mono may cause issues. The baseline build (Step 2) for Mono is `./build.sh mono+libs`, but after making code changes to Mono, developers need a way to rebuild just the Mono component incrementally. Without an explicit build command, developers may not know how to rebuild after making changes but before running tests. Consider retaining the build command for incremental rebuilds after the initial baseline.
Test:
./build.sh clr.host
cd src/tests
./build.sh mono debug /p:LibrariesConfiguration=debug
./run.sh</details>
Removed the note about skipping build steps for docs/infra.
Member
Author
|
/ba-g markdown only |
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to make it more deterministically build before trying to test and commit.