[cDAC] Convert cDAC dump tests to run on Helix by max-charlamb · Pull Request #124782 · dotnet/runtime

max-charlamb · 2026-02-24T03:42:34Z

Replace the DumpCreation + DumpTest ADO stages in runtime-diagnostics.yml with a single CdacDumpTests stage that builds, prepares a Helix payload, and sends dump generation + test execution to Helix machines.

Changes:

Add BuildDebuggeesOnly target to DumpTests.targets for building debuggees without generating dumps
Add PrepareHelixPayload target + XUnitConsoleRunner package to csproj; generates debuggee-metadata.props from GetDumpTypes for dynamic discovery
Create cdac-dump-helix.proj Helix SDK project that imports the generated metadata, builds per-OS commands for dump generation and xunit test execution
Update runtime-diagnostics.yml to use Helix instead of ADO stages
Add windows_arm64 platform support

dotnet-policy-service · 2026-02-24T03:43:15Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR converts the cDAC dump tests from running as ADO pipeline stages to running on Helix infrastructure. The change simplifies the pipeline by replacing separate DumpCreation and DumpTest stages with a single CdacDumpTests stage that generates dumps and runs tests on Helix machines.

Changes:

Adds Helix infrastructure for remote test execution
Enables windows_arm64 platform support
Consolidates dump generation and testing into a single Helix-based stage

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
cdac-dump-helix.proj	New Helix SDK project that orchestrates dump generation and test execution on Helix; defines commands, queues, and work items
Microsoft.Diagnostics.DataContractReader.DumpTests.csproj	Adds PrepareHelixPayload target to stage test artifacts and debuggees; adds XUnitConsoleRunner package reference
DumpTests.targets	Adds BuildDebuggeesOnly target for building debuggees without generating dumps locally
runtime-diagnostics.yml	Replaces two-stage ADO workflow (DumpCreation + DumpTest) with single CdacDumpTests stage using Helix

...ative/managed/cdac/tests/DumpTests/Microsoft.Diagnostics.DataContractReader.DumpTests.csproj

eng/pipelines/runtime-diagnostics.yml

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

...ative/managed/cdac/tests/DumpTests/Microsoft.Diagnostics.DataContractReader.DumpTests.csproj

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj

eng/pipelines/runtime-diagnostics.yml

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

src/native/managed/cdac/tests/DumpTests/cdac-dump-xplat-test-helix.proj

src/native/managed/cdac/tests/DumpTests/cdac-dump-gen-helix.proj

eng/pipelines/runtime-diagnostics.yml

...ative/managed/cdac/tests/DumpTests/Microsoft.Diagnostics.DataContractReader.DumpTests.csproj

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

eng/pipelines/runtime-diagnostics.yml:170

shouldContinueOnError: true at the matrix/job level will be forwarded into send-to-helix-inner-step.yml (via global-build-job.yml) and causes the Helix send step to run with continueOnError: true. That can leave the job/stage as SucceededWithIssues even when Helix dump tests fail, effectively masking test failures. Consider keeping shouldContinueOnError false here, or add an explicit final step to fail the job when Agent.JobStatus is SucceededWithIssues (matching the previous DumpTest stage behavior).

            - task: PublishTestResults@2
              inputs:
                testResultsFormat: xUnit
                testResultsFiles: '**/*.xml'

eng/pipelines/runtime-diagnostics.yml

...ative/managed/cdac/tests/DumpTests/Microsoft.Diagnostics.DataContractReader.DumpTests.csproj

Replace the DumpCreation + DumpTest ADO stages in runtime-diagnostics.yml with a single CdacDumpTests stage that builds debuggees on ADO and sends dump generation + test execution to Helix machines. Flow: ADO builds runtime + debuggees, prepares a Helix payload containing test DLLs, debuggee binaries, and auto-generated dump type metadata. On Helix, each debuggee is run to produce a crash dump, then xunit tests validate the dumps. Changes: - Add BuildDebuggeesOnly target to DumpTests.targets using Exec with dotnet build (ensures implicit NuGet restore, matching _GenerateLocalDump) - Add PrepareHelixPayload target + XUnitConsoleRunner package to csproj; copies tests + debuggees, generates debuggee-metadata.props from GetDumpTypes for dynamic debuggee discovery - Create cdac-dump-helix.proj Helix SDK project that imports the generated metadata, builds per-OS dump generation + xunit test execution commands - Update runtime-diagnostics.yml with single CdacDumpTests stage - Add windows_arm64 platform support Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Use simple key-value parameter defaults instead of nested object format. ADO step templates don't support the type/default nested syntax and interpret it as an Object value, causing 'Unable to convert from Object to String' parse errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CCWInterfaces, RCW, and RCWCleanupList use COM interop APIs that are only available on Windows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

max-charlamb · 2026-03-19T15:31:03Z

/ba-g

From copilot CI analysis:

All CI failures are unrelated to this PR. Here's the breakdown:

  runtime-diagnostics: ✅ All green

  All 4 Helix legs passed (linux-x64, linux-arm64, windows-x64, windows-arm64), plus the Build/cDAC/DAC jobs. The new WindowsOnly marking for CCWInterfaces, RCW, and RCWCleanupList is working
  correctly.

  runtime pipeline failures (16 total): All known issues, no PR correlation

   - 12 osx/ios/tvos build errors — All fail at dlls/mscordac/CMakeLists.txt:119 or Mono build. Matches known issue #125757 ("osx builds failing with CMake error"). Not related to this PR at all.
   - 2 MsQuic test failures (linux-x64, linux-arm64) — System.Net.Quic.Tests.MsQuicPlatformDetectionTests. Matches known issue #123216 (MsQuic OOM on AzureLinux).
   - 1 osx-arm64 NativeAOT failure in the second build (1341834) — same CMake issue.

  No correlation with PR-changed files.

max-charlamb added the area-Diagnostics-coreclr label Feb 24, 2026

Copilot AI review requested due to automatic review settings February 24, 2026 03:42

dotnet-policy-service bot assigned max-charlamb Feb 24, 2026

Copilot started reviewing on behalf of max-charlamb February 24, 2026 03:43 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

...ative/managed/cdac/tests/DumpTests/Microsoft.Diagnostics.DataContractReader.DumpTests.csproj Outdated Show resolved Hide resolved

eng/pipelines/runtime-diagnostics.yml Outdated Show resolved Hide resolved

jkotas reviewed Feb 24, 2026

View reviewed changes

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj Outdated Show resolved Hide resolved

max-charlamb force-pushed the cdac-dumptests-helix-2 branch from d82438f to 3f3aefe Compare February 24, 2026 17:32

Copilot AI review requested due to automatic review settings February 24, 2026 17:46

max-charlamb force-pushed the cdac-dumptests-helix-2 branch from 3f3aefe to d1ce702 Compare February 24, 2026 17:46

Copilot started reviewing on behalf of max-charlamb February 24, 2026 17:47 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

...ative/managed/cdac/tests/DumpTests/Microsoft.Diagnostics.DataContractReader.DumpTests.csproj Outdated Show resolved Hide resolved

max-charlamb force-pushed the cdac-dumptests-helix-2 branch 2 times, most recently from 3f93840 to 569cce9 Compare February 24, 2026 19:41

Copilot AI review requested due to automatic review settings February 24, 2026 19:41

Copilot started reviewing on behalf of max-charlamb February 24, 2026 19:42 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj Outdated Show resolved Hide resolved

eng/pipelines/runtime-diagnostics.yml Outdated Show resolved Hide resolved

max-charlamb force-pushed the cdac-dumptests-helix-2 branch from 569cce9 to 3d682f9 Compare February 25, 2026 17:57

Copilot AI review requested due to automatic review settings February 26, 2026 17:53

Copilot started reviewing on behalf of max-charlamb February 26, 2026 17:54 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 2, 2026 21:55

Copilot started reviewing on behalf of max-charlamb March 2, 2026 21:56 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

eng/pipelines/runtime-diagnostics.yml Outdated Show resolved Hide resolved

eng/pipelines/runtime-diagnostics.yml Outdated Show resolved Hide resolved

...ative/managed/cdac/tests/DumpTests/Microsoft.Diagnostics.DataContractReader.DumpTests.csproj Outdated Show resolved Hide resolved

max-charlamb marked this pull request as ready for review March 16, 2026 13:38

max-charlamb requested review from noahfalk and rcj1 March 16, 2026 13:38

This was referenced Mar 16, 2026

/root/helix/work/correlation/scripts/<hash>/execute.sh: Permission denied dotnet/dnceng#3412

Open

Microsoft.Extensions.Hosting.Tests.BackgroundServiceExceptionTests.BackgroundService_AsynchronousException_StopAsync_ThrowsException failed #125550

Closed

noahfalk approved these changes Mar 18, 2026

View reviewed changes

max-charlamb and others added 12 commits March 18, 2026 11:00

update pipeline

06d6a04

add xplat support

db2c21d

pass SourcePlatforms as env vars

c578728

run xplat if scheduled

dda62e0

platform fix

7629dc2

try to deduplicate

7be05f1

filter windows only debuggees on non-windows platforms

c63554d

disable osx runs

f2d5522

fix comments

c45e1da

Mark new COM debuggees as WindowsOnly

bdc9e02

CCWInterfaces, RCW, and RCWCleanupList use COM interop APIs that are only available on Windows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 18, 2026 20:31

max-charlamb force-pushed the cdac-dumptests-helix-2 branch from ce104df to bdc9e02 Compare March 18, 2026 20:31

Copilot AI reviewed Mar 18, 2026

View reviewed changes

This was referenced Mar 19, 2026

wasm build failure in CI #117017

Open

osx builds failing with CMake error #125757

Closed

max-charlamb merged commit 97cc027 into dotnet:main Mar 19, 2026
155 of 173 checks passed

max-charlamb deleted the cdac-dumptests-helix-2 branch March 19, 2026 15:32

Conversation

max-charlamb commented Feb 24, 2026

Uh oh!

dotnet-policy-service bot commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

max-charlamb commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants