[cDAC] Implement SOSDacImpl.GetRCWInterfaces by Copilot · Pull Request #124939 · dotnet/runtime

Copilot · 2026-02-27T03:19:59Z

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

…fix filter condition and cleanup Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

docs/design/datacontracts/BuiltInCOM.md

src/coreclr/vm/datadescriptor/datadescriptor.inc

...tive/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/BuiltInCOM.cs

rcj1 · 2026-02-27T15:04:16Z

@copilot consolidate into version 1 everywhere

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot · 2026-02-27T15:14:50Z

@copilot consolidate into version 1 everywhere

Already consolidated in 5d2fc47: BuiltInCOM_2 removed, GetRCWInterfaces moved into BuiltInCOM_1, datadescriptor.inc stays at version 1, and the docs updated to a single Version 1 section.

rcj1 · 2026-02-27T20:58:41Z

@copilot please fix the build break.

  /Users/runner/work/1/s/src/coreclr/vm/runtimecallablewrapper.h:58:2: error: FEATURE_COMINTEROP is required for this file
     58 | #error FEATURE_COMINTEROP is required for this file
        |  ^
  In file included from /Users/runner/work/1/s/src/coreclr/debug/datadescriptor-shared/datadescriptor.cpp:4:
  In file included from /Users/runner/work/1/s/src/coreclr/vm/datadescriptor/datadescriptor.h:17:
  In file included from /Users/runner/work/1/s/src/coreclr/vm/runtimecallablewrapper.h:67:
  /Users/runner/work/1/s/src/coreclr/vm/comcache.h:14:2: error: FEATURE_COMINTEROP is required for this file
     14 | #error FEATURE_COMINTEROP is required for this file
        |  ^
  /Users/runner/work/1/s/src/coreclr/vm/comcache.h:20:10: fatal error: 'ctxtcall.h' file not found
     20 | #include <ctxtcall.h>
        |          ^~~~~~~~~~~~

…COMINTEROP Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot · 2026-02-27T21:02:44Z

@copilot consolidate into version 1 everywhere

Fixed in 95723c1. The #include "runtimecallablewrapper.h" in datadescriptor.h is now guarded with #ifdef FEATURE_COMINTEROP so it won't be included on platforms without COM interop support (macOS, Linux).

rcj1 · 2026-02-27T22:28:35Z

@copilot look into the dump test failure https://github.com/dotnet/runtime/pull/124939/checks?check_run_id=65204536256

…n GC handle table Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

…add per-entry loop Co-authored-by: rcj1 <44248479+rcj1@users.noreply.github.com>

rcj1 · 2026-03-09T22:48:39Z

@copilot please fix the merge conflicts.

… tests Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot · 2026-03-09T23:20:17Z

@copilot please fix the merge conflicts.

Fixed in 5154e1b. The main branch had two PRs merged that our branch was missing:

GetCCWInterfaces — restored COMInterfacePointerData, GetCCWFromInterfacePointer, GetCCWInterfaces to IBuiltInCOM.cs and BuiltInCOM_1.cs; restored CCW fields in ComCallWrapper.cs, SimpleComCallWrapper.cs, ComMethodTable.cs; restored cdac_data fields in comcallablewrapper.h; restored TearOff declarations in stdinterfaces.h/stdinterfaces_wrapper.cpp; restored CCWInterfaces debuggee; added CCWInterfacesDumpTests.cs (since BuiltInCOMDumpTests.cs now uses the BuiltInCOM debuggee for RCW cleanup list tests).
GetLoaderAllocatorHeaps — restored full GetLoaderAllocatorHeapNames/GetLoaderAllocatorHeaps implementations in SOSDacImpl.cs; restored ILoader.cs, Loader_1.cs, LoaderAllocator.cs, VirtualCallStubManager.cs, ISOSDacInterface13Tests.cs; added VirtualCallStubManager/ComMethodTable to DataType.cs and CCW globals to Constants.cs.

All 1130 unit tests pass.

…ions and tests" This reverts commit 5154e1b.

max-charlamb

lgtm pretty good from a cDAC perspective mod single comment

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/RCW.cs

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs

--- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com> Co-authored-by: rcj1 <rachel.jarvi@gmail.com> Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com> Co-authored-by: rcj1 <44248479+rcj1@users.noreply.github.com>

Initial plan

c0f8333

Copilot AI assigned Copilot and rcj1 Feb 27, 2026

Copilot started work on behalf of rcj1 February 27, 2026 03:20 View session

github-actions bot added the area-Diagnostics-coreclr label Feb 27, 2026

Copilot AI and others added 2 commits February 27, 2026 03:46

Implement GetRCWInterfaces cDAC API in IBuiltInCOM (contract version 2)

f08a49a

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Fix critical bug: RCW.InterfaceEntries is inline array, not pointer; …

07fa9dd

…fix filter condition and cleanup Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Implement cDAC API GetRCWInterfaces in IBuiltInCOM~~ Implement cDAC GetRCWInterfaces API in IBuiltInCOM (contract v2) Feb 27, 2026

Copilot finished work on behalf of rcj1 February 27, 2026 04:00

rcj1 reviewed Feb 27, 2026

View reviewed changes

docs/design/datacontracts/BuiltInCOM.md Show resolved Hide resolved

Copilot started work on behalf of rcj1 February 27, 2026 15:02 View session

rcj1 reviewed Feb 27, 2026

View reviewed changes

src/coreclr/vm/datadescriptor/datadescriptor.inc Outdated Show resolved Hide resolved

rcj1 reviewed Feb 27, 2026

View reviewed changes

...tive/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/BuiltInCOM.cs Outdated Show resolved Hide resolved

Consolidate GetRCWInterfaces into BuiltInCOM version 1

5d2fc47

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot AI changed the title ~~Implement cDAC GetRCWInterfaces API in IBuiltInCOM (contract v2)~~ Implement cDAC GetRCWInterfaces API in IBuiltInCOM Feb 27, 2026

Copilot finished work on behalf of rcj1 February 27, 2026 15:09

Copilot started work on behalf of rcj1 February 27, 2026 15:09 View session

Copilot finished work on behalf of rcj1 February 27, 2026 15:15

Copilot started work on behalf of rcj1 February 27, 2026 20:58 View session

Fix build break: guard runtimecallablewrapper.h include with FEATURE_…

95723c1

…COMINTEROP Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot finished work on behalf of rcj1 February 27, 2026 21:03

Copilot started work on behalf of rcj1 February 27, 2026 22:28 View session

Fix dump test: create strong GCHandle for rcwObject so it's visible i…

e68733c

…n GC handle table Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Fix GetRCWInterfaces DEBUG validation: always pass &pNeededLocal and …

a6d72e0

…add per-entry loop Co-authored-by: rcj1 <44248479+rcj1@users.noreply.github.com>

Copilot finished work on behalf of max-charlamb March 6, 2026 19:27

rcj1 added 4 commits March 6, 2026 11:54

validation

187bf27

fix

93e0d71

Add debug information for itemIndex validation

2a91881

fix

4eca4b4

Copilot started work on behalf of rcj1 March 9, 2026 22:48 View session

Fix merge conflicts with main: restore CCW/Loader implementations and…

5154e1b

… tests Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot AI requested review from BrzVlad, janvorli and kg as code owners March 9, 2026 23:19

Copilot finished work on behalf of rcj1 March 9, 2026 23:21

rcj1 added 2 commits March 9, 2026 16:44

Revert "Fix merge conflicts with main: restore CCW/Loader implementat…

e9bfe35

…ions and tests" This reverts commit 5154e1b.

merge

556b9e3

rcj1 removed request for BrzVlad, janvorli and kg March 10, 2026 01:22

max-charlamb approved these changes Mar 10, 2026

View reviewed changes

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/RCW.cs Show resolved Hide resolved

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs Show resolved Hide resolved

Update RCWInterfacesDumpTests.cs

cd11f3f

jkoritzinsky approved these changes Mar 10, 2026

View reviewed changes

Fix null check for interfacesLocal initialization

40198c2

rcj1 merged commit 9a9b322 into main Mar 11, 2026
110 of 114 checks passed

rcj1 deleted the copilot/implement-getrcwinterfaces-api branch March 11, 2026 03:54

dotnet-maestro bot mentioned this pull request Mar 12, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#5408

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cDAC] Implement SOSDacImpl.GetRCWInterfaces#124939

[cDAC] Implement SOSDacImpl.GetRCWInterfaces#124939
rcj1 merged 32 commits intomainfrom
copilot/implement-getrcwinterfaces-api

Copilot AI commented Feb 27, 2026 •

edited by rcj1

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rcj1 commented Feb 27, 2026

Uh oh!

Copilot AI commented Feb 27, 2026

Uh oh!

rcj1 commented Feb 27, 2026

Uh oh!

Copilot AI commented Feb 27, 2026

Uh oh!

rcj1 commented Feb 27, 2026

Uh oh!

rcj1 commented Mar 9, 2026

Uh oh!

Copilot AI commented Mar 9, 2026

Uh oh!

max-charlamb left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Copilot AI commented Feb 27, 2026 • edited by rcj1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rcj1 commented Feb 27, 2026

Uh oh!

Copilot AI commented Feb 27, 2026

Uh oh!

rcj1 commented Feb 27, 2026

Uh oh!

Copilot AI commented Feb 27, 2026

Uh oh!

rcj1 commented Feb 27, 2026

Uh oh!

rcj1 commented Mar 9, 2026

Uh oh!

Copilot AI commented Mar 9, 2026

Uh oh!

max-charlamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Feb 27, 2026 •

edited by rcj1

Loading