Skip to content

[NO-MERGE, NO-REVIEW] Experiment: try remove test exclusions #125117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrek-msft wants to merge 1 commit into from
+0 −3
Closed

[NO-MERGE, NO-REVIEW] Experiment: try remove test exclusions #125117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...raries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ private void SetSecret(string id, string key, string value)
}

[Fact]
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was previously skipped on iOS/tvOS under ActiveIssue(60584), but other tests in this file are still skipped for the same issue. Either the underlying problem is fixed (in which case the remaining 60584 skips should also be removed/updated), or it’s still present and this re-enables a known failing test on those platforms.

Suggested change
[Fact]
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]

Copilot uses AI. Check for mistakes.
[ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void AddUserSecrets_FindsAssemblyAttribute()
{
var randValue = Guid.NewGuid().ToString();
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public class ArrayTests : IDisposable
";

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void DifferentConfigSources_Merged_KeysAreSorted()
Comment on lines 49 to 50
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were previously disabled on iOS/tvOS via ActiveIssue(60583). Removing the exclusion without a corresponding fix (or confirmation that 60583 is resolved) is likely to reintroduce known failures and make CI unreliable on those platforms. If the issue is still active, keep the attribute; if it’s resolved, consider removing/adjusting all remaining 60583-based skips in related configuration tests so platform coverage is consistent.

Copilot uses AI. Check for mistakes.
{
var config = BuildConfig();
Expand Down Expand Up @@ -76,7 +75,6 @@ public void DifferentConfigSources_Merged_KeysAreSorted()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void DifferentConfigSources_Merged_WithOverwrites()
{
var config = BuildConfig();
Expand Down
Loading