Skip to content

Simplify TrimmerSingleWarn intermediate assembly update using MSBuild item Update #125630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −13
Draft

Simplify TrimmerSingleWarn intermediate assembly update using MSBuild item Update #125630

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a50f1ff
Initial plan
Copilot Mar 16, 2026
7ed1e6e
Replace complex TrimmerSingleWarn intersection pattern with simpler U…
Copilot Mar 16, 2026
1cb9ce2
Fix MSB4096: qualify TrimmerSingleWarn metadata reference in Update c…
Copilot Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,19 +227,9 @@ Copyright (c) .NET Foundation. All rights reserved.
<ItemGroup>
<!-- Don't collapse to a single warning for the intermediate assembly.
This sets metadata on the items in ResolvedFileToPublish that came from IntermediateAssembly. -->
<!-- Find ResolvedFileToPublish _except_ IntermediateAssembly -->
<__SingleWarnIntermediateAssembly Include="@(ResolvedFileToPublish)" />
<__SingleWarnIntermediateAssembly Remove="@(IntermediateAssembly)" />
<!-- Subtract these from ResolvedFileToPublish, to get the intersection. -->
<_SingleWarnIntermediateAssembly Include="@(ResolvedFileToPublish)" />
<_SingleWarnIntermediateAssembly Remove="@(__SingleWarnIntermediateAssembly)" />
<!-- Set metadata on the intersection. -->
<_SingleWarnIntermediateAssembly>
<TrimmerSingleWarn Condition=" '%(_SingleWarnIntermediateAssembly.TrimmerSingleWarn)' == '' ">false</TrimmerSingleWarn>
</_SingleWarnIntermediateAssembly>
<!-- Replace these items in ResolvedFileToPublish. -->
<ResolvedFileToPublish Remove="@(_SingleWarnIntermediateAssembly)" />
<ResolvedFileToPublish Include="@(_SingleWarnIntermediateAssembly)" />
<ResolvedFileToPublish Update="@(IntermediateAssembly)">
<TrimmerSingleWarn Condition=" '%(ResolvedFileToPublish.TrimmerSingleWarn)' == '' ">false</TrimmerSingleWarn>
</ResolvedFileToPublish>

<!-- Don't collapse to a single warning for project references -->
<ResolvedFileToPublish Condition=" '%(ResolvedFileToPublish.ProjectReferenceOriginalItemSpec)' != '' ">
Expand Down
Loading