Skip to content

Try checking for Darwin and Clang in addition to AppleClang#125758

Closed
jtschuster wants to merge 1 commit intodotnet:mainfrom
jtschuster:AppleBuildFix
Closed

Try checking for Darwin and Clang in addition to AppleClang#125758
jtschuster wants to merge 1 commit intodotnet:mainfrom
jtschuster:AppleBuildFix

Conversation

@jtschuster
Copy link
Member

The build machines may have had some changes that cause this workaround to be more fragile. Try checkign for CMAKE_SYSTEM_NAME == "Darwin" AND CMAKE_CXX_COMPILER_ID == "Clang" in addition to CMAKE_CXX_COMPILER_ID == "AppleClang"

@jtschuster jtschuster self-assigned this Mar 19, 2026
Copilot AI review requested due to automatic review settings March 19, 2026 00:34
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the native CMake compiler configuration to make the $<LINK_GROUP:RESCAN> no-op workaround less dependent on AppleClang detection, improving resiliency on Darwin build machines whose toolchains may report Clang instead.

Changes:

  • Extend the $<LINK_GROUP:RESCAN> no-op enablement to also apply when CMAKE_SYSTEM_NAME == "Darwin" and CMAKE_CXX_COMPILER_ID == "Clang".
  • Keep the existing AppleClang-specific logic for forcing the classic linker on Xcode 15.
  • Minor whitespace cleanup in the Emscripten version mismatch warning block.

@jkotas
Copy link
Member

jkotas commented Mar 19, 2026

The build machines may have had some changes

Where did the non-standard (?) clang version that got installed on the build machines come from?

@jkotas
Copy link
Member

jkotas commented Mar 19, 2026

The new osx-x64 build failure is #104105

@jkotas
Copy link
Member

jkotas commented Mar 19, 2026

Superseded by #125763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants