Fix JIT: Arm IsContainableImmed to handle shifts#125938
Open
sachinsharma3191 wants to merge 6 commits intodotnet:mainfrom
Open
Fix JIT: Arm IsContainableImmed to handle shifts#125938sachinsharma3191 wants to merge 6 commits intodotnet:mainfrom
sachinsharma3191 wants to merge 6 commits intodotnet:mainfrom
Conversation
- Add GT_LSH, GT_RSH, GT_RSZ, GT_ROL, GT_ROR cases to IsContainableImmed - ARM64: use emitter::isValidImmShift for shift amount validation - ARM32: validate shift amount in 0-32 range - Update ContainCheckShiftRotate to use CheckImmedAndMakeContained for consistency Fixes dotnet#125578 Made-with: Cursor
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125578