Open
Conversation
Contributor
giritrivedi
commented
Mar 26, 2026
- Remove duplicate instructions.
- Add missing comma
* Add missing comma
Contributor
Author
|
Failures are unrelated due to the changes. |
Contributor
Author
|
cc : @uweigand |
Contributor
Author
|
Hello, can someone review and merge this PR ? . |
Contributor
Author
|
hi @steveisok , Is there anything needed from my end before this gets merged ? |
Member
|
I think somebody from the s390x community should at least comment on the validity of this change. |
uweigand
reviewed
Apr 7, 2026
Member
|
Thanks a lot @uweigand ! Just FYI: CI is broken due to infra problems, so unfortunately we will have to wait a bit (hopefully just a day or two) |
Taking care of review comments.
uweigand
approved these changes
Apr 7, 2026
Contributor
uweigand
left a comment
There was a problem hiding this comment.
This version LGTM, thanks!
tannergooding
approved these changes
Apr 19, 2026
Member
|
CI should be mostly sorted now and we should at least get a green Build Analysis run, allowing it to be merged without bypassing any checks. |
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.