[mono] Compile runtime with MBR support by default on Android and Browser#47785
Merged
lambdageek merged 3 commits intodotnet:masterfrom Feb 4, 2021
Merged
[mono] Compile runtime with MBR support by default on Android and Browser#47785lambdageek merged 3 commits intodotnet:masterfrom
lambdageek merged 3 commits intodotnet:masterfrom
Conversation
lambdageek
requested review from
akoeplinger,
marek-safar,
steveisok and
vargaz
as code owners
|
Tagging subscribers to this area: @CoffeeFlux Issue DetailsCompile the runtime with MBR support by default. We did some perf investigations #46842 (comment) that showed that there is some impact but it was not clearly actionable.
|
This comment has been minimized.
This comment has been minimized.
lambdageek
changed the title
Member
Author
|
Updated the PR to just enable MBR on Android and Browser |
51 tasks
vargaz
reviewed
Feb 3, 2021
lambdageek
commented
Feb 3, 2021
src/mono/netcore/System.Private.CoreLib/System.Private.CoreLib.csproj
Outdated
Show resolved
Hide resolved
akoeplinger
reviewed
Feb 4, 2021
akoeplinger
approved these changes
Feb 4, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile the runtime with MBR support by default on Android and Browser. Other platforms can continue to opt in with
/p:MonoMetadataUpdate=true.We did some perf investigations #46842 (comment) that showed that there is some impact but it was not clearly actionable.