When marshalling a layout class, fall-back to dynamically marshalling the type if it doesn't match the static type in the signature.#50137
Merged
jkoritzinsky merged 3 commits intodotnet:mainfrom Mar 24, 2021
Conversation
… the type if it doesn't match the static type in the signature.
AaronRobinsonMSFT
approved these changes
Mar 24, 2021
jkoritzinsky
commented
Mar 24, 2021
jkoritzinsky
commented
Mar 24, 2021
This was referenced Apr 2, 2021
Closed
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we switched the struct marshalling system to be IL based, we accidentally stopped checking if the passed in object matched the type in the signature in the "layout class" case (where we have a sequential or explicit layout
classtype). This causes failures to marshal the derived types correctly since only the base type ends up being marshalled.This PR fixes the regression by falling back to dynamically marshalling the object if the runtime type does not match the declared type.
Fixes #49857