Skip to content

Fix assertion failure / crash in multi-core JIT#53573

Merged
kouvel merged 2 commits intodotnet:mainfrom
kouvel:StopProfileFix
Jun 2, 2021
Merged

Fix assertion failure / crash in multi-core JIT#53573
kouvel merged 2 commits intodotnet:mainfrom
kouvel:StopProfileFix

Conversation

@kouvel
Copy link
Contributor

@kouvel kouvel commented Jun 2, 2021 •
edited
Loading

Fix assertion failure / crash in multi-core JIT
ac54b9d 
- When the recorder times out it doesn't actually stop profiling, but writes out the profile
- The app may later stop profiling, and then it tries to write the profile again
- PR #48326 fairly expected that the profile is only written once (some state is mutated)
- The non-timeout stop-profile path was also not stopping the timer
- Fix for #53014 in main
@kouvel kouvel added this to the 6.0.0 milestone Jun 2, 2021
@kouvel kouvel requested review from jkotas and noahfalk June 2, 2021 04:02
@kouvel kouvel self-assigned this Jun 2, 2021
@kouvel kouvel mentioned this pull request Jun 2, 2021
Closed
jkotas
jkotas approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kouvel kouvel merged commit f495f7e into dotnet:main Jun 2, 2021
@kouvel kouvel deleted the StopProfileFix branch June 2, 2021 14:29
@mangod9 mangod9 mentioned this pull request Jun 16, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

@noahfalk noahfalk Awaiting requested review from noahfalk

Assignees

@kouvel kouvel

Labels

area-TieredCompilation-coreclr

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kouvel @jkotas